Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbeaver: fix hash #81853

Merged
merged 1 commit into from
Mar 6, 2020
Merged

dbeaver: fix hash #81853

merged 1 commit into from
Mar 6, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 6, 2020

Motivation for this change

Fixes #81829
cc: @stigtsp @jojosch

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jojosch March 6, 2020 00:56
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 6, 2020
stigtsp
stigtsp approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Tested execution of dbeaver binary.

Result of nixpkgs-review pr 81853 1

1 package built:
  • dbeaver

jojosch
jojosch approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@jojosch jojosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The same thing happened in #71512.

Upstream seems to have added a few new commits to the 7.0 release branch: dbeaver/dbeaver@7.0.0...release_7_0_0

@marsam marsam merged commit dea93ef into NixOS:master Mar 6, 2020
@marsam marsam deleted the fix-dbeaver-hash branch March 6, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojosch jojosch jojosch approved these changes

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbeaver: hash mismatch
3 participants
@marsam @stigtsp @jojosch