Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdf-parser: init at 0.7.4 #82278

Merged
merged 1 commit into from
Mar 28, 2020
Merged

pdf-parser: init at 0.7.4 #82278

merged 1 commit into from
Mar 28, 2020

Conversation

lightdiscord
Copy link
Member

Motivation for this change

Add missing package for #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Mar 10, 2020
@alyssais alyssais added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 12, 2020
@FRidh
Copy link
Member

FRidh commented Mar 14, 2020

please rebase

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 14, 2020
@lightdiscord
Copy link
Member Author

lightdiscord commented Mar 15, 2020 •
edited
Loading

Rebase done. I don't know why but ofborg appears to be stuck. 🤔

@etu etu merged commit 362a983 into NixOS:master Mar 28, 2020
@lightdiscord lightdiscord deleted the package-request/pdf-parser branch March 28, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lightdiscord @FRidh @jtojnar @Ma27 @etu @alyssais