Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/netdata: add module package option #82286

Merged
merged 1 commit into from
Mar 21, 2020
Merged

nixos/netdata: add module package option #82286

merged 1 commit into from
Mar 21, 2020

Conversation

yesbox
Copy link
Contributor

@yesbox yesbox commented Mar 10, 2020 •
edited
Loading

Adds a "package" option to the netdata module.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Mar 10, 2020 •
edited
Loading

I only see one netdata package. What is your use for this option? Oh I see... spoke too soon. Yeah, this makes sense to me 👍

@yesbox
Copy link
Contributor Author

yesbox commented Mar 11, 2020 via email •
edited
Loading

@yesbox
Copy link
Contributor Author

yesbox commented Mar 21, 2020

Ping @Mic92, would you mind merging this?

@Mic92 Mic92 merged commit bfb747a into NixOS:master Mar 21, 2020
@yesbox yesbox deleted the netdata_module_package_option branch March 22, 2020 21:18
@yesbox yesbox mentioned this pull request Dec 25, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yesbox @aanderse @Mic92