Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-manager: 2020-01-04 -> 2020-03-07 #82347

Merged
merged 1 commit into from
Mar 16, 2020
Merged

home-manager: 2020-01-04 -> 2020-03-07 #82347

merged 1 commit into from
Mar 16, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 11, 2020 •
edited
Loading

Motivation for this change

It has been a couple of months since the last bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented Mar 11, 2020

I successfully rebuilt my system including my home-manager configuration with this.

@Mic92 Mic92 requested a review from rycee March 11, 2020 22:13
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 11, 2020
@timokau
Copy link
Member Author

timokau commented Mar 16, 2020

It looks like rycee has his hands full. Since he didn't object to updates in the past, I'm going to assume this is fine.

@timokau timokau merged commit 04a0ff8 into NixOS:master Mar 16, 2020
@timokau timokau deleted the home-manager-2020-03-07 branch March 16, 2020 16:36
@rycee
Copy link
Member

rycee commented Mar 16, 2020

Sorry. Yes, I have no problem with updates at any time. I should remove myself as the maintainer of this package, it was the person adding the package that put my nick there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timokau @rycee