Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass: don't rebuild when adding extensions, pass-audit: 0.1 -> 1.0.1 #82691

Merged
merged 2 commits into from
Mar 28, 2020
Merged

pass: don't rebuild when adding extensions, pass-audit: 0.1 -> 1.0.1 #82691

merged 2 commits into from
Mar 28, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 15, 2020

Motivation for this change
  • Update passExtensions.pass-audit to 1.0.1 and improve the derivation (16001ea)
  • Fix pass.withExtensions to avoid rebuilds of pkgs.pass when adding new extensions (
    187f3e7)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
passExtensions.pass-audit: 0.1 -> 1.0.1, refactor
16001ea 
Updates to v1.0.1[1] which supports subdirs and zxcvbn[2]-based
complexity checks. Also, the following things changed:

* Add separate output for man-pages
* Enable test-suite (after adding a patch which mocks the
  `pwnedpasswords.com`).
* Added myself as maintainer.

[1] https://github.com/roddhjav/pass-audit/releases/tag/v1.0.1 /
    https://github.com/roddhjav/pass-audit/releases/tag/v1.0

[2] https://pypi.org/project/zxcvbn-python/
@Ma27
pass: allow adding extensions without rebuilding the package
187f3e7 
Until now, `pkgs.pass` was rebuilt entirely when adding an extension
using the `pass.withExtensions`-function. This is fixed now by removing the
linking of extensions from the fixupPhase and merge all paths (including
those from pkgs.pass) together in using `pkgs.buildEnv`.
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 15, 2020
@claudiiii
Copy link
Contributor

Builds and works on linux and darwin, thank you 👍.

@globin globin merged commit 16c8590 into NixOS:master Mar 28, 2020
@Ma27 Ma27 deleted the pass-exts branch March 28, 2020 10:03
@abathur abathur mentioned this pull request Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@lovek323 lovek323 Awaiting requested review from lovek323

@tadfisher tadfisher Awaiting requested review from tadfisher

@the-kenny the-kenny Awaiting requested review from the-kenny

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ma27 @claudiiii @globin