Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pjsip: 2.9 → 2.10 #83225

Merged
merged 1 commit into from
Mar 29, 2020
Merged

pjsip: 2.9 → 2.10 #83225

merged 1 commit into from
Mar 29, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 23, 2020

Motivation for this change

New features: https://github.com/pjsip/pjproject/releases/tag/2.10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl vbgl added the 8.has: package (update) This PR updates a package to a newer version label Mar 23, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 23, 2020
@vbgl
Copy link
Contributor Author

vbgl commented Mar 24, 2020

@GrahamcOfBorg build mumsi

bhipple
bhipple approved these changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 83225 1

1 package marked as broken and skipped: - ring-daemon
2 package built: - mumsi - pjsip

@bhipple bhipple merged commit eda60c5 into NixOS:master Mar 29, 2020
@vbgl vbgl deleted the pjsip-2.10 branch March 29, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbgl @bhipple