Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtorrent-raster: 1.1.11 -> 1.2.5; qbittorrent: 4.2.1 -> 4.2.2 #83414

Merged
merged 1 commit into from
Mar 29, 2020
Merged

libtorrent-raster: 1.1.11 -> 1.2.5; qbittorrent: 4.2.1 -> 4.2.2 #83414

merged 1 commit into from
Mar 29, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Mar 26, 2020

Motivation for this change

Updated qbittorrent and its dependency. libtorrent-raster to their latest versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    CC @Phreedom

@ofborg ofborg bot requested review from Anton-Latukha and Phreedom March 26, 2020 10:42
bhipple
bhipple approved these changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 83414 1

11 package built: - btfs - deluge - kodiPlugins.yatp - libtorrentRasterbar - python27Packages.libtorrentRasterbar - python37Packages.libtorrentRasterbar - python38Packages.libtorrentRasterbar - qbittorrent - qbittorrent-nox - springLobby - tribler

@bhipple bhipple merged commit eb2f8d2 into NixOS:master Mar 29, 2020
@ghost ghost mentioned this pull request Apr 8, 2020
Merged
10 tasks
ghost
ghost reviewed Apr 8, 2020
View reviewed changes
pkgs/development/libraries/libtorrent-rasterbar/default.nix
@@ -17,13 +17,14 @@ in stdenv.mkDerivation {
src = fetchFromGitHub {
owner = "arvidn";
repo = "libtorrent";
rev = "libtorrent_${formattedVersion}";
rev = "libtorrent-${formattedVersion}";
sha256 = "0nwdsv6d2gkdsh7l5a46g6cqx27xwh3msify5paf02l1qzjy4s5l";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You never actually updated the hash, so this is still using 1.1.11 from the binary cache.

@ghost
Copy link

ghost commented Apr 8, 2020

If you had changed the hash this would have broken deluge. Please look twice next time ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@Anton-Latukha Anton-Latukha Awaiting requested review from Anton-Latukha

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dasj19 @bhipple