-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rofi-emoji: init at 2.1.2 #83753
rofi-emoji: init at 2.1.2 #83753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd vote for patching all dependencies into the script (e.g. by using wrapProgram --prefix PATH
). Also, when testing on NixOS, a so-called emoji file can't be found. Maybe a path to it should be fixed as well.
It appears that the reason that file can't be found is that I could make a patch that forces the path to be Which do you think is more preferable? I lean towards modifying the wrapper, but I'll defer to you (or anybody else who has an opinion on this). EDIT: Would this matter in the case where the plugin has no |
This plugin is intended to be supplied to the `rofi` wrapper through an override: pkgs.rofi.override { plugins = [ rofi-emoji ]; }
I opted to modify the wrapper. It appears to work for me. (Removed all local |
I'll leave it here since it isn't clearly documented. To install
And to link the emoji picker to, say,
With that, pressing |
This plugin is intended to be supplied to the
rofi
wrapper through anoverride:
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Takes inspiration from and relies on #83136.
This comes with a script that uses binaries like
notify-send
,wl-copy
,xclip
,xsel
:https://github.com/Mange/rofi-emoji/blob/61d6a795ef3703c4c5babd7dc861041c4f7d7e50/clipboard-adapter.sh.
Should I patch these to be absolute store paths withsubstituteAll
(and thus relying on X11 binaries on Wayland and vice-versa), or is it fine as-is? Or is there another solution I haven't though of? I currently don't have any problems, but I'm on Arch and have these binaries in my PATH already.I'm still curious whether or not it's "fine" to rely on the xclip/wl-clipboard binaries unconditionally. Maybe I should add
waylandSupport ? true
andx11Support ? true
and make them optional (but requiring at least one of those to be set)?To test, run the following:
If you see a rofi window pop up with emoji, it works! Now see if you can select an emoji (with enter) and paste it somewhere.
If you can, I likely don't need to substitute the binaries inclipboard-adapter.sh
; otherwise, I probably will have to.EDIT: Updated the above easy-test command to point to new commits.