Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zotero: make wrapGAppsHook work #83806

Merged
merged 1 commit into from
Mar 31, 2020
Merged

zotero: make wrapGAppsHook work #83806

merged 1 commit into from
Mar 31, 2020

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Mar 30, 2020

Motivation for this change

Fixes #83699

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Mar 30, 2020 •
edited
Loading

@GrahamcOfBorg eval

dealing with an issue with ofborg at the moment, my apologies

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Mar 31, 2020
@veprbl veprbl merged commit a74d70b into NixOS:master Mar 31, 2020
veprbl pushed a commit that referenced this pull request Mar 31, 2020
@NickHu @veprbl
zotero: make wrapGAppsHook work
f2417ef 
(cherry picked from commit 4665e31)
cc #83806
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 31, 2020
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@NickHu @stigok
zotero: make wrapGAppsHook work
a443927 
(cherry picked from commit 4665e31)
cc NixOS#83806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zotero cannot open file chooser dialog
3 participants
@NickHu @grahamc @veprbl