Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nexus: 3.20.1-01 -> 3.22.0-02 #83988

Merged
merged 1 commit into from
Apr 5, 2020
Merged

nexus: 3.20.1-01 -> 3.22.0-02 #83988

merged 1 commit into from
Apr 5, 2020

Conversation

armin1402
Copy link
Contributor

@armin1402 armin1402 commented Apr 1, 2020 •
edited
Loading

Motivation for this change

https://help.sonatype.com/repomanager3/release-notes/2020-release-notes

Security Fix

A critical security vulnerability has been found in all versions of NXRM 3 up to and including 3.21.1. For details, please see CVE-2020-10199, CVE-2020-10203, CVE-2020-10204.

Sonatype recommends that administrators upgrade to 3.21.2 or newer immediately.

Maybe this pr should be backported to 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fadenb
fadenb approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@fadenb fadenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but did not test yet

@alyssais alyssais added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 2, 2020
@armin1402
Copy link
Contributor Author

ping
@ironpinguin
@aespinosa
@zaninime

@ironpinguin
Copy link
Contributor

Looks good for me

@nlewo
Copy link
Member

nlewo commented Apr 4, 2020

@GrahamcOfBorg test nexus

@nlewo nlewo merged commit fc536d3 into NixOS:master Apr 5, 2020
@nlewo
Copy link
Member

nlewo commented Apr 5, 2020

Backported to 20.03 in 92e20dc.

I'm however not sure about 19.09 since the version gap is important: 3.18.1-01 -> 3.22.
@Ma27 wdyt?

@fadenb
Copy link
Contributor

fadenb commented Apr 17, 2020

@nlewo @Ma27 as I understand it the issue affects the version in 19.09. As it is a quite serious problem I believe it should be backported to 19.09

"Sonatype recommends that administrators running 3.21.2 and earlier upgrade immediately."

Additionally a Metasploit module was publicly released to exploit the issue so now it is really easy to do ( https://packetstormsecurity.com/files/157261/nexus_repo_manager_el_injection.rb.txt)

@zaninime
Copy link
Contributor

Yes this should be backported too.

@zaninime zaninime mentioned this pull request Apr 17, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadenb fadenb fadenb approved these changes

@ironpinguin ironpinguin ironpinguin approved these changes

@aespinosa aespinosa Awaiting requested review from aespinosa

@zaninime zaninime Awaiting requested review from zaninime

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@armin1402 @ironpinguin @nlewo @fadenb @zaninime @alyssais