Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kscreen: Fix #82141 #84194

Merged
merged 1 commit into from
Apr 4, 2020
Merged

kscreen: Fix #82141 #84194

merged 1 commit into from
Apr 4, 2020

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Apr 3, 2020

This fixes #82141 (kscreen not showing display layout, upstream issue https://bugs.kde.org/show_bug.cgi?id=417316).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edolstra edolstra requested a review from ttuegel as a code owner April 3, 2020 16:05
@ofborg ofborg bot added 6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Apr 3, 2020
@worldofpeace
Copy link
Contributor

Perfect 👍

ttuegel
ttuegel approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@ttuegel ttuegel merged commit 045384a into NixOS:master Apr 4, 2020
@edolstra edolstra deleted the kscreen-fix branch April 4, 2020 18:09
@worldofpeace worldofpeace added this to the 20.03 milestone Apr 4, 2020
@worldofpeace
Copy link
Contributor

This was backported to 20.03 in 7d80362.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

kscreen: display configuration lacks screen layout settings
3 participants
@edolstra @worldofpeace @ttuegel