Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zenith: 0.8.0 -> 0.8.1 #84260

Merged
merged 2 commits into from
Apr 5, 2020
Merged

zenith: 0.8.0 -> 0.8.1 #84260

merged 2 commits into from
Apr 5, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Apr 4, 2020

Motivation for this change

0.8.1 has support for the htop's "p mode"  @evils-devils . It behaves almost exactly but for some reason I see things like "Web Content" instead of the "firefox" process. bvaisvil/zenith#15

Things done

I removed platforms.x86 temporary just to see if it builds for aarch64 this time and if not so I can report the exact error message upstream at bvaisvil/zenith#19

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/cj484xb1pqp8k7fs2p68lilfn0zgyyb7-zenith-0.8.0 34.8M
/nix/store/q2p6ylffsvpvqxf5p648nj7s3b4zw5f6-zenith-0.8.1 34.8M

@marsam marsam merged commit b5a382e into NixOS:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants