-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bash-completion: 2.9 -> 2.10 #84485
bash-completion: 2.9 -> 2.10 #84485
Conversation
Seems like gcc completions assume x86 CPU. |
a0457c4
to
c187bb2
Compare
@GrahamcOfBorg build bash-completion |
Chances are this is broken on macOS, and this is an important package, can somebody run this on Darwin? |
c187bb2
to
36c50a3
Compare
@GrahamcOfBorg build bash-completion |
36c50a3
to
c5d79de
Compare
stdenv for darwin on staging is broken, okay then... Rebased newest staging, but I'm not sure if it's going to help with anything. Oh well, if Darwin is broken, it likely doesn't block this package update. |
@GrahamcOfBorg build bash-completion |
c5d79de
to
bdb2bed
Compare
Thanks. Also pushed GNOME Shell fix, which would have been broken by this. |
Motivation for this change
Getting pytest 5.4 to work step-by-step.
Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandbox
innix.conf
on non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in
./result/bin/
)Determined the impact on package closure size (by running
nix path-info -S
before and after)Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.
Also, I tested whether this works with
unset BASH_COMPLETION_VERSINFO; . result/etc/profile.d/bash_completion.sh
in nix-shell. I'm pretty sure I could have done it in a smarter way, but at the very least, it has shown that unzip supports files withaab
extension which was introduced in 2.10 (see https://github.com/scop/bash-completion/blob/master/CHANGES).