LLVM: Always pass host/target info to compiler-rt/libstdcxxClang #84531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
TravisWhitaker
force-pushed
the
cross-clang
branch
2 times, most recently
from
3a1d157
to
c9aa1da
Compare
|
Oh this reminds me, there are some things I synced up to version 9 on master and 20.03, but not 10. Let me do that first. |
|
Did that in #85167. I suppose I can rebase this later today. |
Ericson2314
force-pushed
the
cross-clang
branch
from
c9aa1da
to
74f3b25
Compare
|
I guess this is just barely in-bounds for master rather than staging. |
|
@Ericson2314 Thanks! |
|
I think this causes the regression in #85622 |
rrbutani
added
the
6.topic: llvm/clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, for LLVM 5-10, information about the host platform is always passed to compiler-rt's build system (even if
stdenv.hostPlatform.useLLVMisn't set) and to clang as-targetand compiler-rt flags in libstdcxxClang's CC wrapper. These fixes allowllvmPackages_*.stdenvto be used for cross builds and fixes #40934I'd appreciate review from @LnL7 and @ElvishJerricco, who I know have poked at this stuff before, as well as anyone else familiar with the cross build machinery.
I wasn't able to figure out how the clang-wrapper gets crtbegin.o, etc. in the non cross case, so there's a good chance these flags should be added somewhere else.