-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
just: 0.4.5 -> 0.5.10 #84770
just: 0.4.5 -> 0.5.10 #84770
Conversation
This one didn't work for me.
|
Alright... New error...
Maybe add a WIP to the title of the pull request? |
@GrahamcOfBorg build just |
@privateseabass, Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff - changes requested
built with nixpkgs-review
just --help
works
https://github.com/NixOS/nixpkgs/pull/84770
1 package built:
just
# Run "cargo test" without test case "edit", | ||
# since test case "edit" needs "cat". | ||
checkPhase = '' | ||
runHook preCheck | ||
echo "Running cargo cargo test | ||
--lib | ||
--test completions | ||
--test init | ||
--test integration | ||
--test interrupts | ||
--test invocation_directory | ||
--test readme | ||
--test search | ||
--test shell | ||
--test working_directory | ||
-- ''${checkFlags} ''${checkFlagsArray+''${checkFlagsArray[@]}}" | ||
|
||
cargo test \ | ||
--lib \ | ||
--test completions \ | ||
--test init \ | ||
--test integration \ | ||
--test interrupts \ | ||
--test invocation_directory \ | ||
--test readme \ | ||
--test search \ | ||
--test shell \ | ||
--test working_directory \ | ||
-- ''${checkFlags} ''${checkFlagsArray+''${checkFlagsArray[@]}} | ||
runHook postCheck | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just skip the two failing cases, instead of enumerating all the working ones?
# Run "cargo test" without test case "edit", | |
# since test case "edit" needs "cat". | |
checkPhase = '' | |
runHook preCheck | |
echo "Running cargo cargo test | |
--lib | |
--test completions | |
--test init | |
--test integration | |
--test interrupts | |
--test invocation_directory | |
--test readme | |
--test search | |
--test shell | |
--test working_directory | |
-- ''${checkFlags} ''${checkFlagsArray+''${checkFlagsArray[@]}}" | |
cargo test \ | |
--lib \ | |
--test completions \ | |
--test init \ | |
--test integration \ | |
--test interrupts \ | |
--test invocation_directory \ | |
--test readme \ | |
--test search \ | |
--test shell \ | |
--test working_directory \ | |
-- ''${checkFlags} ''${checkFlagsArray+''${checkFlagsArray[@]}} | |
runHook postCheck | |
''; | |
checkPhase = '' | |
runHook preCheck | |
echo "Running cargo test -- | |
--skip edit | |
--skip run_shebang | |
''${checkFlags} ''${checkFlagsArray+''${checkFlagsArray[@]}}" | |
cargo test -- \ | |
--skip edit \ | |
--skip run_shebang \ | |
''${checkFlags} ''${checkFlagsArray+"''${checkFlagsArray[@]}"} | |
runHook postCheck | |
''; |
@@ -20,22 +20,50 @@ rustPlatform.buildRustPackage rec { | |||
export USER=just-user | |||
export USERNAME=just-user | |||
|
|||
sed -i tests/integration.rs \ | |||
sed -i tests/*.rs \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sed -i tests/*.rs \ | |
sed -i src/justfile.rs tests/*.rs \ |
Then the sed -i src/justfile.rs
block can be removed.
@filalex77, Thanks for the suggestions!! |
@privateseabass, @filalex77, @Mic92 Thank you!! |
Motivation for this change
Update
just
to the latest release.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)