-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xfce: update most packages #85318
xfce: update most packages #85318
Conversation
@GrahamcOfBorg build xfce.exo xfce.gigolo xfce.parole xfce.thunar xfce.tumbler xfce.xfburn xfce.xfce4-battery-plugin xfce.xfce4-clipman-plugin xfce.xfce4-cpugraph-plugin xfce.xfce4-dict xfce.xfce4-eyes-plugin xfce.xfce4-fsguard-plugin xfce.xfce4-genmon-plugin xfce.xfce4-mpc-plugin xfce.xfce4-netload-plugin xfce.xfce4-notes-plugin xfce.xfce4-notifyd xfce.xfce4-panel xfce.xfce4-power-manager xfce.xfce4-pulseaudio-plugin xfce.xfce4-screenshooter xfce.xfce4-sensors-plugin xfce.xfce4-session xfce.xfce4-settings xfce.xfce4-systemload-plugin xfce.xfce4-taskmanager xfce.xfce4-terminal xfce.xfce4-timer-plugin xfce.xfce4-vala-panel-appmenu-plugin xfce.xfce4-weather-plugin xfce.xfce4-windowck-plugin xfce.xfdashboard xfce.xfdesktop |
@GrahamcOfBorg build xfce.exo xfce.gigolo xfce.parole xfce.thunar xfce.tumbler xfce.xfburn xfce.xfce4-battery-plugin xfce.xfce4-clipman-plugin xfce.xfce4-cpugraph-plugin xfce.xfce4-dict xfce.xfce4-embed-plugin xfce.xfce4-eyes-plugin xfce.xfce4-fsguard-plugin xfce.xfce4-genmon-plugin xfce.xfce4-hardware-monitor-plugin xfce.xfce4-icon-theme xfce.xfce4-mailwatch-plugin xfce.xfce4-mpc-plugin xfce.xfce4-netload-plugin xfce.xfce4-notes-plugin xfce.xfce4-notifyd xfce.xfce4-panel xfce.xfce4-power-manager xfce.xfce4-pulseaudio-plugin xfce.xfce4-screenshooter xfce.xfce4-sensors-plugin xfce.xfce4-session xfce.xfce4-settings xfce.xfce4-systemload-plugin xfce.xfce4-taskmanager xfce.xfce4-terminal xfce.xfce4-timer-plugin xfce.xfce4-vala-panel-appmenu-plugin xfce.xfce4-weather-plugin xfce.xfce4-windowck-plugin xfce.xfdashboard xfce.xfdesktop |
@GrahamcOfBorg build xfce.exo xfce.gigolo xfce.parole xfce.thunar xfce.tumbler xfce.xfburn xfce.xfce4-battery-plugin xfce.xfce4-clipman-plugin xfce.xfce4-cpugraph-plugin xfce.xfce4-dict xfce.xfce4-embed-plugin xfce.xfce4-eyes-plugin xfce.xfce4-fsguard-plugin xfce.xfce4-genmon-plugin xfce.xfce4-hardware-monitor-plugin xfce.xfce4-icon-theme xfce.xfce4-mailwatch-plugin xfce.xfce4-mpc-plugin xfce.xfce4-netload-plugin xfce.xfce4-notes-plugin xfce.xfce4-notifyd xfce.xfce4-panel xfce.xfce4-power-manager xfce.xfce4-pulseaudio-plugin xfce.xfce4-screenshooter xfce.xfce4-sensors-plugin xfce.xfce4-session xfce.xfce4-settings xfce.xfce4-systemload-plugin xfce.xfce4-taskmanager xfce.xfce4-terminal xfce.xfce4-timer-plugin xfce.xfce4-vala-panel-appmenu-plugin xfce.xfce4-weather-plugin xfce.xfce4-windowck-plugin xfce.xfdashboard xfce.xfdesktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really the the appmenu plugin anymore and should remove myself as a maintainer, but I mean yeah, the changes look good!
@GrahamcOfBorg test xfce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ran every default program in a VM.
Actually, how are we going to handle migration for eb19356 ? |
I also thing we removed gtk2 from exo already dd8c333. gtk2 support is going to be removed anyways IIRC, and we're going to release 20.09 with a new version of XFCE. |
Maybe just throw message: xfce4-dict-plugin = throw "xfce4-dict-plugin is now part of xfce4-dict."; |
Some XFCE applications and plugins still uses gtk2. Some other core components ( With the next XFCE release we expect the definitive remove of gtk2, though. |
Hmm, I guess we can just clean it up when they release. |
Sounds good, there's an alias section in xfce/default.nix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash the fixup and merge is fine 👍
- The xfce4-dict-plugin is now part of xfce4-dict - See https://goodies.xfce.org/projects/panel-plugins/xfce4-dict-plugin - Throws a message
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)