jwhois: fix path to lynx in $lynx/etc/jwhois.conf #8696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbx6spp
changed the title
|
|
||
| stdenv.mkDerivation { | ||
| name = "jwhois-4.0"; | ||
|
|
||
|
|
||
| lynx = pkgs.lynx; |
There was a problem hiding this comment.
If you pass lynx as an argument instead of pkgs you do not need this line.
There was a problem hiding this comment.
Thanks fixed in latest.
mbbx6spp
force-pushed
the
fix-whois
branch
2 times, most recently
from
9eefa4e
to
20c9110
Compare
| postInstall = "ln -s jwhois $out/bin/whois"; | ||
| postInstall = '' | ||
| ln -s jwhois $out/bin/whois | ||
| sed -i -e "s|/usr/bin/lynx|$lynx/bin/lynx|g" $out/etc/jwhois.conf |
There was a problem hiding this comment.
I don't want to nitpick, but you can use
sed -i -e "s|/usr/bin/lynx|${lynx}/bin/lynx|g" $out/etc/jwhois.conf
(not the curly braces). That way you do not need inherit lynx; and the specification of the build inputs.
There was a problem hiding this comment.
Thanks I didn't know about that gem. Updated PR. Thanks.
Fixes issues found when jwhois attempts to launch terminal browser
(lynx) for HTTP whois queries, for example:
$ whois blah.io
[Querying http://www.io.io/cgi-bin/whois]
[HTTP: Unable to run web browser: /usr/bin/lynx: No such file or directory]
Tested via:
grep lynx \
/nix/store/bymgmn2vvw1n7nbb1isy87xg94s8f2ml-jwhois-4.0/etc/jwhois.conf \
| cut -f2 -d'"' \
| xargs stat -t
|
Pushed. Such a simple fix lying here so long. |
vcunat
pushed a commit
that referenced
this pull request
Jul 30, 2015
Close #8696. Fixes issues found when jwhois attempts to launch terminal browser (lynx) for HTTP whois queries, for example: $ whois blah.io [Querying http://www.io.io/cgi-bin/whois] [HTTP: Unable to run web browser: /usr/bin/lynx: No such file or directory] Tested via: grep lynx \ /nix/store/bymgmn2vvw1n7nbb1isy87xg94s8f2ml-jwhois-4.0/etc/jwhois.conf \ | cut -f2 -d'"' \ | xargs stat -t (cherry picked from commit a9e2cf0)
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
Close NixOS#8696. Fixes issues found when jwhois attempts to launch terminal browser (lynx) for HTTP whois queries, for example: $ whois blah.io [Querying http://www.io.io/cgi-bin/whois] [HTTP: Unable to run web browser: /usr/bin/lynx: No such file or directory] Tested via: grep lynx \ /nix/store/bymgmn2vvw1n7nbb1isy87xg94s8f2ml-jwhois-4.0/etc/jwhois.conf \ | cut -f2 -d'"' \ | xargs stat -t (cherry picked from commit a9e2cf0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues found when jwhois attempts to launch terminal browser (lynx) for HTTP whois queries, for example:
Tested via:
Should return with exit code 0.