Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal2nix in release20.03 is built using GHC881 which is not in cache #87184

Closed
Shimuuar opened this issue May 7, 2020 · 4 comments
Closed

Comments

@Shimuuar
Copy link

Shimuuar commented May 7, 2020

Describe the bug
Attempt to install cabal2nix on stable channel (release-20.03) results in huge build which include such monster as GHC.

To Reproduce
Just type: $ nix-shell -p cabal2nix --dry-run you'll be greeted with long list of packages.

Expected behavior
I would expect that it should be either downloaded from binary cache or at very least will use GHC from binary cache. Digging through commit history show that cabal2nix started using GHC881 since cfb580f. Now it should probably use either GHC883 explicitly or just one from haskellPackages

Notify maintainers
@peti

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.35, NixOS, 20.03.1754.b0e3df2f843 (Markhor)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.3.4`
 - channels(root): `"home-manager-20.03, nixos-20.03.1754.b0e3df2f843"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
@endgame
Copy link
Contributor

endgame commented May 7, 2020

Looks like it's failing because bootstrapping ghc 8.8.1 segfaults? https://hydra.nixos.org/build/118296850/nixlog/1/tail

I can get ghc 8.8.2 and 8.8.3 from cache just fine; is it worth supporting 8.8.1 at this point?

Note also that haskellPackages.cabal2nix is a cache hit because it looks like haskellPackages is still using ghc 8.6.5

@cdepillabout
Copy link
Member

I believe the reason cabal2nix comes from 8.8.1 (and not 8.6.5) is because it is kind of awkward to override Haskell packages in a package set when cabal2nix comes from that same package set:

#83098 (comment)

Looks like it's failing because bootstrapping ghc 8.8.1 segfaults?

I'm not sure why this would be happening, but an easy workaround here is to just send a PR that gets cabal2nix from ghc-8.8.3 instead of ghc-8.8.1.

@endgame
Copy link
Contributor

endgame commented May 8, 2020

Sounds promising, but I will not have time to do this.

peti added a commit that referenced this issue May 8, 2020
The new version supports older versions of Cabal again and therefore doesn't
need any overrides or a newer compiler to build. The default ghc-8.6.x in the
release-20.03 release branch can compile it just fine.

Fixes #87184.
@peti
Copy link
Member

peti commented May 8, 2020

Fixed in 6b2dc0e.

@peti peti closed this as completed May 8, 2020
stigok pushed a commit to stigok/nixpkgs that referenced this issue Jun 12, 2020
The new version supports older versions of Cabal again and therefore doesn't
need any overrides or a newer compiler to build. The default ghc-8.6.x in the
release-20.03 release branch can compile it just fine.

Fixes NixOS#87184.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants