-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler-rt: fix build on armv7l #87419
compiler-rt: fix build on armv7l #87419
Conversation
Nice work! We probably should consolidate this with |
Successfully built for
I'm following the pattern in #85945 with enough changes to make it work. I didn't look deeply into why this is an appropriate fix. Someone else would need to write the cover letter for upstreaming. Incidentally, has this been tested in the i486 and i586 cases? I only see a definition of |
Hm, is it actually still causing a rebuild on Darwin or is ofBorg bugged? |
1a11cc7
to
1b0e7b1
Compare
No need for rebuilds on other platforms
1b0e7b1
to
d616ae8
Compare
Related: #87528 |
Motivation for this change
Fixes #87266 - llvmPackages_7.compiler-rt fails to produce output path on armv7l
Still testing the builds, so opening as draft.
See also same change for x86 #85945
cc @matthewbauer @Atemu @TravisWhitaker
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)