Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efivar: fix Could not parse device path: Invalid Argument #89251

Merged
merged 1 commit into from
Jun 3, 2020
Merged

efivar: fix Could not parse device path: Invalid Argument #89251

merged 1 commit into from
Jun 3, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Running efibootmgr -v is broken on unstable as efibootmgr returns Could not parse device path: Invalid Argument.

Upstream issue: rhboot/efibootmgr#133

Fixed by 2 additional patches to efivar.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg mentioned this pull request May 31, 2020
Closed
@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build efibootmgr

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels May 31, 2020
@peterhoeg peterhoeg merged commit c36d87c into NixOS:master Jun 3, 2020
@peterhoeg peterhoeg deleted the f/efivar branch June 3, 2020 09:40
@fabianhauser fabianhauser mentioned this pull request Jun 5, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterhoeg