xorg-server: Fix XKB_BINDIR usage. #8993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, XKB_BINDIR was read inside a loop over the program arguments, so was only read if it had arguments that weren't matched by the first some number of checks.
|
You tested running the patched server, right? |
|
Hmm, from grepping the xserver code, copying the string isn't really needed, but we can leave it there, I suppose. |
|
I've tested that I can now actually run Xorg, yes. I haven't tried the NixOS invocation of it, but it includes the same workaround, just not in a place in a loop that might be called 0 or more times. |
|
I tested and pushed. I'm sorry for the long delay. |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, XKB_BINDIR was read inside a loop over the program
arguments, so was only read if it had arguments that weren't matched by
the first some number of checks.