Storm #901
Storm #901
Conversation
- The bin/storm script makes too many assumptions about file locations and java classpath that I couldn't figure out a better way. Fix jzmq build on NixOS: java source was treated as ASCII.
- Add config to defaults.yaml, to allow topologies to include their own storm.yaml. - Symlink extra jars in lib/ since it's nearly impossible to add a classpath to Storm's config. - Include native jzmq library in java.library.path - Use package default args.
|
adding yourself as a maintainer is not THAT easy. take a look at pkgs/lib/maintainers.nix |
|
Eh :-) you mean the bad alphabetical order? And should "blue" be before "bluescreen" or after? |
|
Woops, don't know how I missed that... Am I still worthy to maintain? |
|
Btw is the policy to use your github username? :$ |
|
Even illiteracy shouldn't matter if you can still maintain the package ;-) I don't know about such a policy, but it seems a good idea to unify identifiers belonging to one person (e-mail prefix, github name, IRC nick, etc.). In my experience it can save some confusion. |
|
hrm I didn't notice "blue" because it was hidden too far away from its proper location :/ am I sill worthy to review? |
|
Ok, take 3. |
|
jzmq from c5750ea fails to build on linux: |
|
@Phreedom that's correct, it's fixed 2 commits later :) which are attached to this pull request. |
vcunat edit: use symlink instead of hardlink (failed for me with a cross-device error), minor whitespace cleanup
|
Pushed with a small amend. Builds on my machine now, so hopefully OK. |
This packages Storm 0.8.2 http://storm-project.net/
I also took the liberty of adding myself as maintainer :-)