Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And atom-beta: 1.43.0-beta0 -> 1.49.0-beta0
This version bump includes an important python2 -> python3 update:
node-gyp 3.7.0 -> 5.1.0 in Atom's apm/package-lock.json, which, per
nodejs/node-gyp#1687, finally allows python3
to be used instead of EOL'd python2 for atom-package installation.
Motivation for this change
Be able to install atom packages without installing python2, which is 5 months past EOL.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
typora
andtermius-app
debs could not be fetched. I didn't look into this further because these only build with allowUnfree../result/bin/
)nix path-info -S
before and after)1301740784 -> 1308167848 ( +0.5% )
Maintainers: @offlinehacker @NeQuissimus @ysndr
Note that there is another open Atom version bump PR: #83340 1.42.0 -> 1.45.0.
(Atom needs to get to 1.48 to fix the python2 problem.)