easypdkprog: init at 1.2

[david-sawatzke]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

The udev rules stuff is taken from the openocd package, but I'm not sure if it works

[danieldk]

Thanks for contributing this derivation! I have added a bunch of suggestions for improvements.

[david-sawatzke]

@danieldk Thanks for the review, should be fine now

[danieldk]

Starts to look good! I added another suggestion to merge postInstall (which was currently not working) and installPhase. postInstall is typically only useful when you use an unchanged installPhase.

Could you split the change where you add yourself to maintainers.nix to a separate commit with the following message?

maintainers: add david-sawatzke

This commit should be ordered before the commit where you add the derivation.

Let me know if you need any help!

[david-sawatzke]

Thanks, regarding:

merge postInstall (which was currently not working)

It seems to work now after being merged, but I don't understand why it didn't work before. Do you have any idea why that's the case?

[danieldk]

It seems to work now after being merged, but I don't understand why it didn't work before. Do you have any idea why that's the case?

preInstall and postInstall are run as hooks in installPhase. The default installPhase looks like this:

installPhase() {
    runHook preInstall

    # Do the installPhase stuff

    runHook postInstall
}

So if you override installPhase they are not run anymore.

[danieldk]

Looks good now, thanks a lot!

Result of nixpkgs-review pr 91671 1

1 package built:

- easypdkprog