Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jabcode: init at git-2020-05-13 #92697

Merged
merged 1 commit into from
Jul 13, 2020
Merged

jabcode: init at git-2020-05-13 #92697

merged 1 commit into from
Jul 13, 2020

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Jul 8, 2020

Motivation for this change

jabcode consists of a library and reader/writer executables for the JAB bar code format. It constitutes the reference implementation of what will be an ISO standard (NP23634).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 8, 2020
@xaverdh
Copy link
Contributor Author

xaverdh commented Jul 11, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Jul 11, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 11, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

timokau
timokau requested changes Jul 13, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks. I'm curious: Is there any real use-case for this already? What's your motivation in packaging this?

pkgs/development/libraries/jabcode/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/jabcode/default.nix

preConfigure = "cd src/${subdir}";

installPhase = if subproject == "library" then ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the library really should be its own derivation, it shares little code with the reader/writer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that, it does share the source as well as some of the build inputs. Also since its all in the same repo upstream, if they decide to e.g. make changes to the build system at some point, they could become more coupled in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel strongly about this, I can decouple them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't feel very strongly. I think dependencies are likely to diverge, but your points are valid as well.

pkgs/development/libraries/jabcode/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@xaverdh
Copy link
Contributor Author

xaverdh commented Jul 13, 2020

Some small nitpicks. I'm curious: Is there any real use-case for this already? What's your motivation in packaging this?

Thanks for reviewing this! Currently its mostly for playing around with it. But I hope that the library part can be reused in zbar, which would make it a lot more useful (because that includes image recognition / scanning capabilities).

@timokau timokau mentioned this pull request Jul 13, 2020
Open
@timokau
Copy link
Member

timokau commented Jul 13, 2020

Currently its mostly for playing around with it.

Alright, probably the purest of open-source motivations :) Thanks for the contribution!

@timokau timokau merged commit be4f99d into NixOS:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_reviewer marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xaverdh @timokau