-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python-cryptography to 1.0. #9274
Conversation
Most importantly, this change depends on #9257. I believe it's the right thing to do, at least generally---without it, and even with the rev of the That said, I did a nox-review run, and while I saw several failures that were clearly issues with the packages in question---a few source URLs no longer work---I am not certain that all the failures were of that sort, and I'm not 100% certain how to sort the wheat from the chaff. |
Does this build ? I get errors about missing |
It does build for me, for python34, which I guess is the default. I'm assuming from the fact that you had to add enum34, that that's not the one you're building against? Trying to work through the issues that arise from 'nox-review' has actually led me to tweak this change a bit (as well as fix what seems to be a bunch of unbuildable packages) in some of the ways you note; I hope to finish working through those issues today, at which time I'll update this PR. |
I'll also note that I think you'll find if you only add those things to buildInputs, openssl (for instance), will fail. I think they need to be propagatedBuildInputs. That said, I am spectacularly ignorant about much of this stuff---I'm no python guy, and I'm a pretty mediocre nix guy to boot. I just want to be able to 'nix-env -i borg'. I'm only taking on all this other stuff in service of getting that working. If someone more conversant and literate about this stuff is willing to take it on, I would be quite happy to step aside; this was not how I anticipated spending my weekend. |
Please rename commit's name following our guide in |
Needed for python-cryptography: 0.6.1 -> 1.0
Needed for python-cryptography: 0.6.1 -> 1.0
Needed for python-cryptography: 0.6.1 -> 1.0
Update propagatedBuildInputs to get proper cffi version and shim packages for older pythons.
It's unfortunate that this changed, but the tarball does appear to have a valid signature.
faa269e
to
5b91f2d
Compare
This is, I believe, as far as I can take this change. Starting from the initial changes (adding This lead me to add three more commits. One upgrades the Then two of the packages that depend on This does not leave an entirely clean build from |
@jagajaga I think all the commits in this PR now conform to the document---thanks for pointing me towards is. |
Update python-cryptography to 1.0.
Thanks! |
This does require upgrading both pyasn1 and crytography-vectors to their
latest versions, as well as adding the idna package.