-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telepresence: fix build #92743
Merged
Merged
telepresence: fix build #92743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
requested changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please make 2 commits, one fixing the build, and one to bump the version.
@@ -8,6 +8,7 @@ let | |||
url = "https://github.com/datawire/sshuttle.git"; | |||
rev = "32226ff14d98d58ccad2a699e10cdfa5d86d6269"; | |||
sha256 = "1q20lnljndwcpgqv2qrf1k0lbvxppxf98a4g5r9zd566znhcdhx3"; | |||
deepClone = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to just add a
preBuild = ''
export SETUPTOOLS_SCM_PRETEND_VERSION="${version}"
'';
MasseGuillaume
force-pushed
the
fix-telepresence
branch
from
July 8, 2020 21:20
5ce12a1
to
196b90a
Compare
MasseGuillaume
changed the title
telepresence: add deepClone = true to make setuptools-scm happy
telepresence: fix build
Jul 8, 2020
Mic92
reviewed
Jul 8, 2020
Mic92
reviewed
Jul 8, 2020
Result of 1 package built:- telepresence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools-scm needs a full git repo in it's source to fetch the
version from the git tag
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)