Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: make services.smartd much more helpful #9280

Merged
merged 1 commit into from
Aug 16, 2015

Conversation

oxij
Copy link
Member

@oxij oxij commented Aug 16, 2015

Now it generates notifications for auto-detected devices as well as
for explicitly configured ones, sends well formed e-mails and supports
immediate wall and xmessage notifications.

@bjornfor
Copy link
Contributor

I didn't test it but it looks good to me.

notifications = {

mail = {
enable = mkOption {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use mkEnableOption.

Now it generates notifications for auto-detected devices as well as
for explicitly configured ones, sends well formed e-mails and supports
immediate `wall` and `xmessage` notifications.
@oxij
Copy link
Member Author

oxij commented Aug 16, 2015

@jagajaga I changed one of them to mkEnableOption, others won't do because they have nontrivial defaults.

@jagajaga
Copy link
Member

My fault, haven't noticed that.

jagajaga added a commit that referenced this pull request Aug 16, 2015
nixos: make services.smartd much more helpful
@jagajaga jagajaga merged commit 7ca6742 into NixOS:master Aug 16, 2015
@oxij oxij deleted the better-smartd branch August 29, 2017 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants