Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

granatier: init at 19.12.3 #92883

Merged
merged 4 commits into from
Jul 19, 2020
Merged

granatier: init at 19.12.3 #92883

merged 4 commits into from
Jul 19, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Jul 10, 2020 •
edited
Loading

Motivation for this change

make granatier application available in kdeApplications

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy requested a review from ttuegel as a code owner July 10, 2020 17:27
@ofborg ofborg bot added 6.topic: qt/kde 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 10, 2020
endgame
endgame suggested changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to build and run with nix-build -A kdeApplications.granatier https://github.com/freezeboy/nixpkgs/archive/49d8c701135792fe257c199a2dd2a8486b4a5e64.tar.gz

Some metadata is missing, please fix.

pkgs/applications/kde/granatier.nix Show resolved Hide resolved
pkgs/applications/kde/granatier.nix Outdated

mkDerivation {
name = "granatier";
meta = with lib; { maintainers = with maintainers; [ freezeboy ]; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set description and license fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@endgame
Copy link
Contributor

endgame commented Jul 11, 2020

Please squash all your changes into a single commit with message granatier: init at 19.12.3. Otherwise, I'm happy with this. Actually getting it merged is above my pay grade, sorry.

@freezeboy
Copy link
Contributor Author

Great, I think the squash can be done while merging the PR

@ttuegel
Copy link
Member

ttuegel commented Jul 13, 2020

@ofborg build granatier

@freezeboy
Copy link
Contributor Author

@ttuegel is it ok for merging ?

@ttuegel ttuegel merged commit 28a408a into NixOS:master Jul 19, 2020
@freezeboy freezeboy deleted the add-granatier branch July 25, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endgame endgame endgame requested changes

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freezeboy @endgame @ttuegel