Merge Ruby versions into one file #9834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikajude
added
0.kind: enhancement
pikajude
force-pushed
the
rubies
branch
3 times, most recently
from
cedc01c
to
8261ea0
Compare
|
It's possible some of the patches changes sources from which autotools generate stuff. The commit looks good to me, but I suppose it's better if some ruby user gives feedback. Trying: @pSub, @cstrahan, @wkennington. |
| ruby_2_2_2 = callPackage ../development/interpreters/ruby/ruby-2.2.2.nix { | ||
| inherit (darwin) libobjc libunwind; | ||
| }; | ||
| inherit (callPackage ../development/interpreters/ruby {}) |
There was a problem hiding this comment.
This should be callPackages (plural).
|
Looks fine |
pikajude
pushed a commit
that referenced
this pull request
Sep 26, 2015
Merge Ruby versions into one file
pikajude
pushed a commit
that referenced
this pull request
Oct 1, 2015
Merge Ruby versions into one file
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes adding new Ruby versions a bit easier and less copy-paste-y, in the style of PHP.
Effective changes:
--without-tkand--without-tclhave been removed from my (unused) version of 1.8.7 as the configure script doesn't recognize them.There is one TODO in the code regarding the new derivation for 1.8.7, which needs autoconf to build when it didn't before. I'm not sure why this is, and I can't build old 1.8.7 on my laptop at all because
missing.hconflicts with a bunch of Libsystem stuff.