Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grass: 6.4.0RC6 -> 7.0.1 #9931

Closed
wants to merge 2 commits into from
Closed

grass: 6.4.0RC6 -> 7.0.1 #9931

wants to merge 2 commits into from

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 18, 2015

This is a rewrite from scratch of the grass derivation.

This addresses #9160; @mucaho: would you like to test?

Briefly tested on linux-x86_64.

@mucaho
Copy link
Contributor

mucaho commented Oct 21, 2015

Thanks again for your effort @vbgl !
Your nix expression compiles fine, however subversion and a gcc are missing as run-time dependencies on my system.
Unfortunately I wasn't able to call Grass geo-algorithms from QGis, but that's not a blocking issue.

@vbgl
Copy link
Contributor Author

vbgl commented Oct 28, 2015 via email

@mucaho
Copy link
Contributor

mucaho commented Nov 1, 2015

Does it work if these dependencies are installed by other means (e.g., separate invocations of nix-env -i)?

Yes, that fixes the issue. I also propose adding a runtime wrapper to grass, so that these runtime dependencies get installed and linked to the executable automatically (possibly like vbgl#1).


But it does not seem to be enough: nothing related to GRASS shows up in the plug-in menu.

On my machine using your new qgis expression, the grass algorithms show up, but still complain about missing dependencies. You bring up the toolbox by clicking on the menu item Processing -> Tollbox and then you have to switch to advanced interface at the bottom of this toolbox. They should show up as Grass GIS 7 commands.


I’ve updated this PR to enable GRASS support into QGIS

Hmm, could the grass build dependency be made optional and disabled by default? I don't think it should be mandatory to always install grass alongside qgis.


As a side note, there is a special directory applications/gis for gis applications. Would it make sense to move the grass expression there?

@vcunat
Copy link
Member

vcunat commented Nov 9, 2015

Looks good to me.

kamilchm pushed a commit to kamilchm/nixpkgs that referenced this pull request Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants