-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdenv: warn about use of inherited lib #111284
Conversation
8f61ce9
to
c96f3cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good but I think we need a release note to document that we're phasing out stdenv.lib
.
Which files would I need to do this in? |
c96f3cd
to
32e8cec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind CI has failed deprecation warnings before, with things like ==
forcing the thunks for otherwise unaccessed attributes, but I hope this one will work out :).
Co-authored-by: John Ericson <git@JohnEricson.me>
Could that be what's causing #109001? |
Motivation for this change
Closes #108938
Removed lib from stdenv (doing this to check ofborg eval)Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)