Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stdenv adapter cruft #171982

Merged
merged 1 commit into from
May 8, 2022
Merged

Remove stdenv adapter cruft #171982

merged 1 commit into from
May 8, 2022

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented May 7, 2022 •
edited
Loading

See commit msgs

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label May 7, 2022
@Artturin Artturin requested a review from Ericson2314 May 7, 2022 18:02
@Ericson2314
Copy link
Member

I would post to Nixpkgs to make sure no one is using or. Or maybe @siraben can teach us how to do a deprecation cycle like stdenv.lib -> lib used?

@Artturin
Copy link
Member Author

Artturin commented May 7, 2022 •
edited
Loading

I would post to Nixpkgs to make sure no one is using or. Or maybe @siraben can teach us how to do a deprecation cycle like stdenv.lib -> lib used?

i searched github for them but all i can find is nixpkgs forks

eg. useGoldLinker is still being used so i didn't remove that

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 7, 2022
@Ericson2314
Copy link
Member

Ericson2314 commented May 7, 2022 •
edited
Loading

Well, on principle, we should still do deprecation cycles. It shouldn't be too hard, and there is no good thing that this stuff is blocking.

As one that loves cleaning things up and thinks stability is overrated in many quarters, I've nonetheless learned that deprecation cycles are good politics, and polite, and simply the right thing to do. If 9 times out of ten no one is using the thing, but 1 time out of 10 you hear back from a user you missed searching, it is worth it.

@Artturin
stdenv: deprecate unused adapters
2d019e0 
stdenv: deprecate addCoverageInstrumentation adapter

this used to be used in nixos/tests but it hasn't been used in nixpkgs
for years

stdenv: deprecate replaceMaintainersField adapter

it was added in 2009 in 01e98e4
by nbp
there are no uses of it in nixpkgs now

stdenv: deprecate validateLicenses adapter

it was added in 2009 in b29073a

unfreePredicate is now handled in ./pkgs/stdenv/generic/check-meta.nix
so this is unnecessary
siraben
siraben approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@siraben siraben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the trace is what we did when we deprecated stdenv.lib and that eased migration since we got pings from different projects that saw the message.

@Ericson2314
Copy link
Member

@siraben how was that trace done?

@Artturin Artturin marked this pull request as ready for review May 8, 2022 16:27
@Ericson2314
Copy link
Member

@siraben In particular, wasn't there a way you use config or something to CI nixpkgs with the deprecated items removed to ensure usages did not crop back in?

Sorry @Artturin I just want to understand the full process so we can replecate it this time and many others.

@Artturin
Copy link
Member Author

Artturin commented May 8, 2022

#111284

@Ericson2314
Copy link
Member

Huh I thought there was more but I won't belabor it :).

@Ericson2314 Ericson2314 merged commit 8b61d66 into NixOS:master May 8, 2022
@Artturin Artturin deleted the cleancruft2 branch May 8, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siraben siraben siraben approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Artturin @Ericson2314 @siraben