Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-bindata: use maintained copy #112164

Merged
merged 2 commits into from Feb 7, 2021
Merged

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Feb 6, 2021

This might need to merge into staging instead?

Motivation for this change

Existing go-bindata is old and unmaintained jteeuwen/go-bindata#5

I've gone with https://github.com/kevinburke/go-bindata since that's the version used by HashiCorp for waypoint, Influx for InfluxDB2, and it's the copy in the homebrew repos.
It also has more recent changes and a more recent release than https://github.com/go-bindata/go-bindata

This more up-to-date copy also correctly resolves the issues we were having packaging waypoint
#100994 (comment)
hashicorp/waypoint#801

The bin works when running --version. It's also using identical details of the copy that was being used in influxdb2 for ages

./result/bin/go-bindata --version
go-bindata 3.22.0 (Go runtime go1.15.7).
Copyright (c) 2010-2015, Jim Teeuwen.
Copyright (c) 2017-2020, Kevin Burke.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    Use maintained version at https://github.com/kevinburke/go-bindata

@06kellyjac 06kellyjac mentioned this pull request Feb 6, 2021
10 tasks
@06kellyjac
Copy link
Member Author

Running a nixpkgs-review right now:

18 packages updated:
browsh docker-machine-kvm2 documize-community go-bindata (2015-10-23 → 3.22.0) go2nix influxdb istioctl kops kops kops magnetico minikube minishift morph ngrok openshift-origin traefik waypoint

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/user/.cache/nixpkgs-review/pr-112164/build.nix
[8/11/21 built, 95 copied (2456.1/2456.4 MiB), 428.5 MiB DL] building ostree-2020.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 112164 run on x86_64-linux 1

18 packages built:
  • browsh
  • docker-machine-kvm2
  • documize-community
  • go-bindata
  • go2nix
  • influxdb2
  • istioctl
  • kops
  • kops_1_16
  • kops_1_17
  • magnetico
  • minikube
  • minishift
  • morph
  • ngrok-1
  • openshift
  • traefik
  • waypoint

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112164 run on x86_64-linux 1

18 packages built:
  • browsh
  • docker-machine-kvm2
  • documize-community
  • go-bindata
  • go2nix
  • influxdb2
  • istioctl
  • kops (kops_1_18)
  • kops_1_16
  • kops_1_17
  • magnetico
  • minikube
  • minishift
  • morph
  • ngrok-1
  • openshift
  • traefik
  • waypoint

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112164 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • magnetico
2 packages failed to build and already failed to build on hydra master:
13 packages built:
  • browsh
  • docker-machine-hyperkit
  • documize-community
  • go-bindata
  • go2nix
  • istioctl
  • kops (kops_1_18)
  • kops_1_16
  • kops_1_17
  • minikube
  • morph
  • ngrok-1
  • traefik

@SuperSandro2000 SuperSandro2000 merged commit 19ec821 into NixOS:master Feb 7, 2021
@06kellyjac 06kellyjac deleted the go-bindata branch February 7, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants