New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-bindata: use maintained copy #112164
go-bindata: use maintained copy #112164
Conversation
Running a nixpkgs-review right now:
|
Result of 18 packages built:
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 18 packages built:
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package marked as broken and skipped:
2 packages failed to build and already failed to build on hydra master:
13 packages built:
|
This might need to merge into staging instead?
Motivation for this change
Existing go-bindata is old and unmaintained jteeuwen/go-bindata#5
I've gone with https://github.com/kevinburke/go-bindata since that's the version used by HashiCorp for waypoint, Influx for InfluxDB2, and it's the copy in the homebrew repos.
It also has more recent changes and a more recent release than https://github.com/go-bindata/go-bindata
This more up-to-date copy also correctly resolves the issues we were having packaging waypoint
#100994 (comment)
hashicorp/waypoint#801
The bin works when running
--version
. It's also using identical details of the copy that was being used in influxdb2 for agesThings done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Use maintained version at https://github.com/kevinburke/go-bindata