Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waypoint: init at 0.1.2 #100994

Closed
wants to merge 1 commit into from
Closed

waypoint: init at 0.1.2 #100994

wants to merge 1 commit into from

Conversation

@winpat
Copy link
Member

@winpat winpat commented Oct 18, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@winpat
Copy link
Member Author

@winpat winpat commented Oct 18, 2020

The executables build successfully. However building a docker image through waypoint build, fails because waypoint can not locate the ceb binary, that got embedded into the executable through go-bindata. Waypoint tries to inject this binary into the docker image to capture logs and enable remote access to container instances.

I've tried to find similar issues in the issue tracker with regards to go-bindata and nix, but could not find anything.

In the fixup phase, patchelf issues a warning (which could just be because the executables are statically compiled):

post-installation fixup
patching script interpreter paths in /nix/store/jzzmajkvqrqq4sdjplj1afs5vr6wy399-waypoint-0.1.2
checking for references to /build/ in /nix/store/jzzmajkvqrqq4sdjplj1afs5vr6wy399-waypoint-0.1.2...
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
building '/nix/store/qdk4xv52v2g60dgc5jnvmmd1vk9c7pvx-user-environment.drv'...
created 101 symlinks in user environment

I've toyed with dontFixup and dontStrip without any success. Maybe @kalbasit has an idea on what I could try next?

@winpat
Copy link
Member Author

@winpat winpat commented Oct 18, 2020

I also created an issue in the upstream repository. They appear to use Nix to manage their go dependencies but not for the build itself.

hashicorp/waypoint#614

@06kellyjac 06kellyjac mentioned this pull request Nov 13, 2020
10 tasks
@winpat
Copy link
Member Author

@winpat winpat commented Nov 14, 2020

Closing in favour of #103754

@winpat winpat closed this Nov 14, 2020
@06kellyjac 06kellyjac mentioned this pull request Feb 6, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant