Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minio: 2021-02-11T08-23-43Z -> 2021-02-14T04-01-33Z #113279

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/minio/minio/releases.

meta.description for minio is: "An S3-compatible object storage server"

meta.homepage for minio is: "https://www.minio.io/"

meta.changelog for minio is: ""

Updates performed
  • Golang update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
minio
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/gjnp6gfl3n59dl2g5xymax2hnxcrqwvp-minio-2021-02-14T04-01-33Z \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A minio https://github.com/r-ryantm/nixpkgs/archive/b1eca3e3374213fb215e8a2fa382fcc4abeb143e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/gjnp6gfl3n59dl2g5xymax2hnxcrqwvp-minio-2021-02-14T04-01-33Z
ls -la /nix/store/gjnp6gfl3n59dl2g5xymax2hnxcrqwvp-minio-2021-02-14T04-01-33Z/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • minio

Maintainer pings

cc @edolstra @bachp @kalbasit for testing.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113279 at b1eca3e run on aarch64-linux 1

1 package built:
2 suggestions:
  • error: no-flags-array

    buildFlagsArray is only intended to be used in Bash, not as a Nix attribute.

    Near pkgs/servers/minio/default.nix:30:3:

       |
    30 |   buildFlagsArray = [
       |   ^
    
  • warning: patch-phase

    patchPhase should not be overridden, use postPatch instead.

    Near pkgs/servers/minio/default.nix:20:3:

       |
    20 |   patchPhase = ''
       |   ^
    

@fabaff
Copy link
Member

fabaff commented Feb 16, 2021

Result of nixpkgs-review pr 113279 run on x86_64-linux 1

1 package built:
  • minio

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ew/pr-113279]$ ./results/minio/bin/minio -v
minio version RELEASE.2021-02-14T04-01-33Z
...ew/pr-113279]$ ./results/minio/bin/minio server .

┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ You are running an older version of MinIO released a long while ago ┃
┃ Update: Run `mc admin update`                                       ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

Endpoint: http://192.168.1.12:9000  http://169.254.34.117:9000  http://127.0.0.1:9000 
[...]

Looks good to me.

Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this updated version on my staging server without issue.

@ryantm ryantm merged commit ef9941e into NixOS:master Feb 18, 2021
@r-ryantm r-ryantm deleted the auto-update/minio branch February 18, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants