Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: Add myself (turion) to maintainer list #113320

Conversation

turion
Copy link
Contributor

@turion turion commented Feb 16, 2021

Motivation for this change

I just noticed that it is now possible to specify maintainers for specific Haskell packages. Here are those that I already maintain on Stackage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turion
Copy link
Contributor Author

turion commented Feb 16, 2021

Side note: Wouldn't it be nice to automatically populate this list with the intersection of nixpkgs and Stackage maintainers?

@cdepillabout
Copy link
Member

@turion Thanks for adding yourself here!

Please make sure that all the packages you've listed here are currently building and not marked broken.

I don't think we have any automatic process for notifying you if the packages get marked broken, but sometimes @peti will ping you in a comment.

@turion turion deleted the dev_add_turion_to_haskell_pkgs_maintainer branch February 17, 2021 07:00
@turion
Copy link
Contributor Author

turion commented Feb 17, 2021

Please make sure that all the packages you've listed here are currently building and not marked broken.

I had a look, pretty sure that this is the case.

I don't think we have any automatic process for notifying you if the packages get marked broken, but sometimes @peti will ping you in a comment.

Maybe we should look into having one? I don't know whether nixpkgs has such a mechanism in general. If it had, we might hook into it somehow. If not, we could still look into writing our own little bot for that maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants