Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nixos/sympa: fix PATH_INFO splitting for sympa-6.2.56 #115727

Closed
wants to merge 1 commit into from
Closed

[20.09] nixos/sympa: fix PATH_INFO splitting for sympa-6.2.56 #115727

wants to merge 1 commit into from

Conversation

sorki
Copy link
Member

@sorki sorki commented Mar 10, 2021 •
edited

Backport #90067

20.09 sympa is now 6.2.60 so this is required.

Our regex for splitting HTTP path into SCRIPT_NAME and PATH_INFO was
incorrect when webLocation was set to "/". Since Sympa 6.2.56 this has
caused the web interface to return "421 Misdirected Request".

Since 6.2.56 Sympa can do the splitting on its own so we can simply
remove it from nginx configuration.

See also:

(cherry picked from commit bd4e4dd)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata @sorki
nixos/sympa: fix PATH_INFO splitting for sympa-6.2.56
eb3a79d 
Our regex for splitting HTTP path into SCRIPT_NAME and PATH_INFO was
incorrect when webLocation was set to "/". Since Sympa 6.2.56 this has
caused the web interface to return "421 Misdirected Request".

Since 6.2.56 Sympa can do the splitting on its own so we can simply
remove it from nginx configuration.

See also:
- sympa-community/sympa#879
- sympa-community/sympa#910
- sympa-community/sympa-community.github.io#53

(cherry picked from commit bd4e4dd)
@sorki sorki requested a review from mmilata March 10, 2021 08:58
mmilata
mmilata approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, this landed in 20.03 and master but not 20.09 due to the timing.

@mmilata mmilata added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 10, 2021
@mweinelt
Copy link
Member

mweinelt commented Jul 5, 2021

Unfortunately NixOS 20.09 has reached its end-of-life status on 2021-07-01, one
month after the release of NixOS 21.05.

Since we do not accept any changes to its branches anymore, I'm closing this pull
request.

@mweinelt mweinelt closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sorki @mweinelt @mmilata