Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gem-config.mathematical: add lasem to rpath #118110

Merged

Conversation

dcbaker
Copy link
Contributor

@dcbaker dcbaker commented Mar 30, 2021

Motivation for this change

This is #87832 rebased on current master, with merge conflicts resolved (which were caused simply by renamed import). As the rebase was absolutely trivial, I've left @Twey's authorship intact

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 30, 2021

Result of nixpkgs-review pr 118110 at 4841a23 run on x86_64-linux 1

476 packages marked as broken and skipped:
  • agdaPackages.iowa-stdlib
  • aldor
  • aqemu
  • atom-beta
  • autotrace
  • awsebcli
  • bareos
  • bonfire
  • cassandra_2_1
  • cassandra_2_2
  • ...
12437 packages skipped due to time constraints:
  • DisnixWebService
  • EBTKS
  • Fabric (python38Packages.Fabric)
  • MIDIVisualizer
  • R
  • Sylk
  • _1password-gui
  • abcl
  • abiword
  • accountsservice
  • ...
22 packages built successfully:
  • asciidoctor
  • cargo
  • git
  • git-latexdiff
  • git-recent
  • git-test
  • kakounePlugins.powerline-kak
  • python38Packages.betamax
  • python38Packages.cryptography
  • python38Packages.factory_boy
  • python38Packages.flask
  • python38Packages.flask_sqlalchemy
  • python38Packages.pyftpdlib
  • python38Packages.pyopenssl
  • python38Packages.pytest-localserver
  • python38Packages.requests
  • python38Packages.responses
  • python38Packages.service-identity
  • python38Packages.sphinx
  • python38Packages.trustme
  • python38Packages.urllib3
  • python38Packages.werkzeug

Result of nixpkgs-review pr 118110 at 4841a23 run on aarch64-linux 1

558 packages marked as broken and skipped:
  • agdaPackages.iowa-stdlib
  • aldor
  • aqemu
  • asymptote
  • autotrace
  • awsebcli
  • bareos
  • belle-sip
  • betaflight-configurator
  • bless
  • ...
11687 packages skipped due to time constraints:
  • DisnixWebService
  • EBTKS
  • Fabric (python38Packages.Fabric)
  • MIDIVisualizer
  • R
  • abcl
  • abiword
  • accountsservice
  • acd-cli
  • adapta-gtk-theme
  • ...
24 packages built successfully:
  • asciidoctor
  • cargo
  • gibo
  • git
  • git-open
  • git-recent
  • greetd.dlm
  • handlr
  • lychee
  • nix-prefetch-git
  • python38Packages.betamax
  • python38Packages.cachecontrol
  • python38Packages.cryptography
  • python38Packages.factory_boy
  • python38Packages.flask
  • python38Packages.flask_sqlalchemy
  • python38Packages.pyjwt
  • python38Packages.pyopenssl
  • python38Packages.requests
  • python38Packages.service-identity
  • python38Packages.sphinx
  • python38Packages.trustme
  • python38Packages.urllib3
  • python38Packages.werkzeug

@SuperSandro2000
Copy link
Member

/rebase staging

@github-actions github-actions bot changed the base branch from master to staging March 31, 2021 00:42
@github-actions github-actions bot closed this Mar 31, 2021
@github-actions
Copy link
Contributor

Rebased, please reopen the pull request to restart CI

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we put patchelf into nativeBuildInputs?

pkgs/development/ruby-modules/gem-config/default.nix Outdated Show resolved Hide resolved
pkgs/development/ruby-modules/gem-config/default.nix Outdated Show resolved Hide resolved
pkgs/development/ruby-modules/gem-config/default.nix Outdated Show resolved Hide resolved
Co-authored-by: Dylan Baker <dylan@pnwbakers.com>
@dcbaker dcbaker force-pushed the submit/rebase-gem-mathmatical branch from 1dec3fd to b81f7f9 Compare March 31, 2021 21:07
@dcbaker
Copy link
Contributor Author

dcbaker commented Mar 31, 2021

I think that's addressed the review comments. I did a quick test and everything seems to be working still.

@SuperSandro2000
Copy link
Member

I think that's addressed the review comments. I did a quick test and everything seems to be working still.

and I before checked that the library is really missing and the name of the library in nixpkgs is differnet.

@SuperSandro2000 SuperSandro2000 merged commit e2191cb into NixOS:staging Apr 1, 2021
@dcbaker dcbaker deleted the submit/rebase-gem-mathmatical branch April 2, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants