-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gem-config.mathematical: add lasem to rpath #118110
gem-config.mathematical: add lasem to rpath #118110
Conversation
Result of 476 packages marked as broken and skipped:
12437 packages skipped due to time constraints:
22 packages built successfully:
Result of 558 packages marked as broken and skipped:
11687 packages skipped due to time constraints:
24 packages built successfully:
|
/rebase staging |
Rebased, please reopen the pull request to restart CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we put patchelf into nativeBuildInputs?
Co-authored-by: Dylan Baker <dylan@pnwbakers.com>
1dec3fd
to
b81f7f9
Compare
I think that's addressed the review comments. I did a quick test and everything seems to be working still. |
and I before checked that the library is really missing and the name of the library in nixpkgs is differnet. |
Motivation for this change
This is #87832 rebased on current master, with merge conflicts resolved (which were caused simply by renamed import). As the rebase was absolutely trivial, I've left @Twey's authorship intact
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)