Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.gdown: fix build #118635

Closed
wants to merge 1 commit into from
Closed

python3Packages.gdown: fix build #118635

wants to merge 1 commit into from

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Apr 5, 2021

Motivation for this change

Failed to build because of missing six dependency. I assume it was previously propagated from some other dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt marked this pull request as ready for review April 5, 2021 23:59
@SuperSandro2000
Copy link
Member

Off topic question: is this tool faster than downloading via the web?

@mweinelt
Copy link
Member Author

mweinelt commented Apr 6, 2021

I don't use it, it is just a dependency somewhere downstream of umap-learn.

@SuperSandro2000
Copy link
Member

Already fixed by a4c701e

@mweinelt mweinelt deleted the python/gdown branch April 7, 2021 23:28
@jonringer
Copy link
Contributor

oh, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mweinelt @SuperSandro2000 @jonringer