Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bat-extras: 20200515-dev -> 2021.04.06 #119689

Merged
merged 1 commit into from Apr 17, 2021
Merged

bat-extras: 20200515-dev -> 2021.04.06 #119689

merged 1 commit into from Apr 17, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Apr 17, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lilyball April 17, 2021 06:35
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 17, 2021 •
edited

Result of nixpkgs-review pr 119689 at 2a441ee run on aarch64-linux 1

5 packages built successfully:
  • bat-extras.batdiff
  • bat-extras.batgrep
  • bat-extras.batman
  • bat-extras.batwatch
  • bat-extras.prettybat

Result of nixpkgs-review pr 119689 at 2a441ee run on x86_64-linux 1

5 packages built successfully:
  • bat-extras.batdiff
  • bat-extras.batgrep
  • bat-extras.batman
  • bat-extras.batwatch
  • bat-extras.prettybat

@dywedir
Copy link
Member

dywedir commented Apr 17, 2021

Thanks!

@dywedir dywedir merged commit 715214f into NixOS:master Apr 17, 2021
@bbigras
Copy link
Contributor Author

bbigras commented Apr 17, 2021

Thank you too :)

@bbigras bbigras deleted the bat-extras branch April 17, 2021 07:32
@lilyball
Copy link
Member

I can't build bat-extras now. It builds, then prints the line "running tests", then fails with exit code 127 (which I believe indicates that it's trying to run a command that doesn't exist). This is on darwin.

@lilyball
Copy link
Member

It looks like it's failing to find getconf. This appears to be in stdenv on Linux, but not on macOS.

@lilyball
Copy link
Member

Adding getconf to the checkInputs on both core and script fixes this. I'd submit a PR but I can't do that for the time being.

@lilyball lilyball mentioned this pull request Apr 20, 2021
Closed
@lilyball
Copy link
Member

I filed this as #119987.

@aaschmid aaschmid mentioned this pull request May 7, 2021
Merged
10 tasks
aaschmid added a commit to aaschmid/nixpkgs that referenced this pull request May 8, 2021
@aaschmid
bat-extras: fix build on Darwin (NixOS#119987)
9f050c6 
introduced by NixOS#119689

Signed-off-by: Andreas Schmid <service@aaschmid.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyball lilyball Awaiting requested review from lilyball

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @r-rmcgibbo @dywedir @lilyball