bat-extras: fix build on Darwin #122069
Merged
bat-extras: fix build on Darwin #122069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaschmid
changed the title
|
Result of 5 packages built successfully:
Result of 5 packages built successfully:
|
| @@ -48,6 +49,7 @@ let | |||
|
|
|||
| # Run the library tests as they don't have external dependencies | |||
| doCheck = true; | |||
| checkInputs = [ getconf ]; | |||
There was a problem hiding this comment.
This should be behind lib.optionals.
There was a problem hiding this comment.
You mean that we just set it on Darwin? I though to keep it always as it is definitively required on both, however somehow included in linux stdenv or somewhat else ...
There was a problem hiding this comment.
I think it is included in glibc for linux. Darwin uses clang so it is not included there. Maybe we want to build it with gccStdenv instead. If not please put it behind stdenv.isDarwin just to be sure.
introduced by NixOS#119689 Signed-off-by: Andreas Schmid <service@aaschmid.de>
aaschmid
force-pushed
the
fix.bat-extras.build.on.darwin
branch
from
0535842
to
9f050c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fix build failure (#119987) on Darwin introduced by #119689
Things done
sandboxinnix.confon non-NixOS linux)nix-build -I nixpkgs=$(pwd) --no-out-link -A bat-extras.batgrep '<nixpkgs>'./result/bin/)nix path-info -Sbefore and after)