New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
steamPackages.steam: 1.0.0.69 -> 1.0.0.70 #120014
Conversation
@@ -2,15 +2,15 @@ | |||
|
|||
let | |||
traceLog = "/tmp/steam-trace-dependencies.log"; | |||
version = "1.0.0.69"; | |||
version = "1.0.0.70"; | |||
|
|||
in stdenv.mkDerivation { | |||
pname = "steam-original"; | |||
inherit version; | |||
|
|||
src = fetchurl { | |||
url = "https://repo.steampowered.com/steam/pool/steam/s/steam/steam_${version}.tar.gz"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use urls and upload it to web.archive.org :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steam keeps an archive of all stable releases at https://repo.steampowered.com/steam/archive/stable/. They keep an archive off all releases at https://repo.steampowered.com/steam/archive/precise/. The stable archive is recommended. The pool/
URL only contains the latest stable and beta, we shouldn't use those URLs, as they are frequently removed. You can read about all of this at https://repo.steampowered.com/steam/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuperSandro2000 @delroth
Can the change to the URL also be done in the current PR?
If so, it would need two commits (imo): one for the version change and the other for the URL change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please. You can throw it into the version update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied this in #120545
Closing in favor of #120545. |
Motivation for this change
The 1.0.0.69 build URL is dead, looks like it got recently removed in favor of 1.0.0.70.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)