Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steamPackages.steam: 1.0.0.69 -> 1.0.0.70 #120014

Closed
wants to merge 1 commit into from

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Apr 21, 2021

Motivation for this change

The 1.0.0.69 build URL is dead, looks like it got recently removed in favor of 1.0.0.70.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -2,15 +2,15 @@

let
traceLog = "/tmp/steam-trace-dependencies.log";
version = "1.0.0.69";
version = "1.0.0.70";

in stdenv.mkDerivation {
pname = "steam-original";
inherit version;

src = fetchurl {
url = "https://repo.steampowered.com/steam/pool/steam/s/steam/steam_${version}.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use urls and upload it to web.archive.org :P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steam keeps an archive of all stable releases at https://repo.steampowered.com/steam/archive/stable/. They keep an archive off all releases at https://repo.steampowered.com/steam/archive/precise/. The stable archive is recommended. The pool/ URL only contains the latest stable and beta, we shouldn't use those URLs, as they are frequently removed. You can read about all of this at https://repo.steampowered.com/steam/.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 @delroth
Can the change to the URL also be done in the current PR?
If so, it would need two commits (imo): one for the version change and the other for the URL change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please. You can throw it into the version update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied this in #120545

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120014 at 46bd459 run on x86_64-linux 1

3 packages built successfully:
  • kodiPackages.steam-launcher
  • lutris
  • steam

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 24, 2021
@mweinelt
Copy link
Member

Closing in favor of #120545.

@mweinelt mweinelt closed this Apr 24, 2021
@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants