Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steamPackages.steam: 1.0.0.69 -> 1.0.0.70, avoid 404s #120545

Merged
merged 2 commits into from Apr 24, 2021
Merged

steamPackages.steam: 1.0.0.69 -> 1.0.0.70, avoid 404s #120545

merged 2 commits into from Apr 24, 2021

Conversation

jonringer
Copy link
Contributor

Motivation for this change

closes #120014 #120539

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 24, 2021
@ofborg ofborg bot requested a review from jagajaga April 24, 2021 16:59
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 120545 at 69a4de6 run on x86_64-linux 1

1 package skipped due to time constraints:
  • lutris
2 packages built successfully:
  • kodiPackages.steam-launcher
  • steam

@mweinelt mweinelt merged commit 324f9af into NixOS:master Apr 24, 2021
@mweinelt
Copy link
Member

3 packages built:
kodiPackages.steam-launcher lutris steam

@jonringer jonringer deleted the bump-steam branch April 24, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinlovinger justinlovinger justinlovinger approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: steam 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @r-rmcgibbo @mweinelt @justinlovinger