Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "firefox-esr: use latest Rust" #121409

Closed
wants to merge 1 commit into from
Closed

Revert "firefox-esr: use latest Rust" #121409

wants to merge 1 commit into from

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented May 1, 2021

Motivation for this change

This reverts commit 903e23a.

Firefox crashes on audio/video since moving to the latest rust version.

Closes: #121408

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Revert "firefox-esr: use latest Rust"
1f41e4f 
This reverts commit 903e23a.

Firefox crashes on audio/video since moving to the latest rust version.

Closes: NixOS#121408
@mweinelt mweinelt requested a review from a user May 1, 2021 16:48
@ghost
Copy link

ghost commented May 1, 2021 •
edited by ghost
Loading

Thanks, but I already pushed it to master 😅
d05202e

@mweinelt
Copy link
Member Author

mweinelt commented May 1, 2021

d05202e#commitcomment-50264282

@mweinelt mweinelt closed this May 1, 2021
@mweinelt mweinelt deleted the firefox-esr-av-crashes branch May 1, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firefox-esr segfaults when playing media
1 participant
@mweinelt