spotify-unwrapped: 20.09 backport: 1.1.26.501 -> 1.1.55.498 #121553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backport the changes in master to 20.09. includes: * ffmpeg4 migration (NixOS#120705) * rename to spotify-unwrapped * high dpi override support * gtk2->gtk3 * 20.09 specific: curlWithGnuTls
sheenobu
force-pushed
the
sheenobu/120705/spotify_ffmpeg_2009
branch
from
609c929
to
a82afb3
Compare
sheenobu
changed the title
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
|
Is there a good reason for the breaking change (i.e. |
|
I only see the |
yurrriq
reviewed
May 20, 2021
| @@ -64,7 +69,7 @@ let | |||
| in | |||
|
|
|||
| stdenv.mkDerivation { | |||
| pname = "spotify"; | |||
| pname = "spotify-unwrapped"; | |||
There was a problem hiding this comment.
Suggested change
| pname = "spotify-unwrapped"; | |
| pname = "spotify"; |
|
Unfortunately NixOS 20.09 has reached its end-of-life status on 2021-07-01, one Since we do not accept any changes to its branches anymore, I'm closing this pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a83c60
backport the changes in master to 20.09.
includes:
Motivation for this change
Mostly #120705 .
NOTE: I am not sure how I feel about renaming this to spotify-unwrapped in 20.09. This will break peoples configs if they have nonFreeFilter set to "spotify" instead of spotify-unwrapped. Those types of changes are best for major upgrades IMO.
The rest of the changes I'm OK with.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)