[ZHF] linuxPackages.dpdk: 20.05 -> 21.02, fix build

[jonringer]

Motivation for this change

bump build, fix it

ZHF: #122042

cc me :)

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[jonringer]

https://github.com/NixOS/nixpkgs/pull/123605

3 packages marked as broken and skipped:
linuxPackages-libre.dpdk linuxPackages_latest-libre.dpdk ofp

3 packages failed to build:
linuxPackages.odp-dpdk linuxPackages.pktgen spdk

15 packages built:
dpdk linuxPackages.dpdk linuxPackages_4_14.dpdk linuxPackages_4_19.dpdk linuxPackages_4_4.dpdk linuxPackages_4_9.dpdk linuxPackages_5_11.dpdk linuxPackages_5_12.dpdk linuxPackages_5_4.dpdk linuxPackages_hardened.dpdk linuxPackages_latest_hardened.dpdk linuxPackages_lqx.dpdk linuxPackages_testing_bcachefs.dpdk linuxPackages_xanmod.dpdk linuxPackages_zen.dpdk

[r-rmcgibbo]

Result of nixpkgs-review pr 123605 at 9b71134 run on x86_64-linux 1

5 packages marked as broken and skipped:

• linuxPackages-libre.dpdk
• linuxPackages_hardkernel_4_14.dpdk
• linuxPackages_hardkernel_latest.dpdk
• linuxPackages_latest-libre.dpdk
• ofp

15 packages skipped due to time constraints:

• dpdk
• odp-dpdk (linuxPackages.odp-dpdk)
• pktgen (linuxPackages.pktgen)
• linuxPackages_4_14.dpdk
• linuxPackages_4_19.dpdk
• linuxPackages_4_4.dpdk
• linuxPackages_4_9.dpdk
• linuxPackages_5_11.dpdk (linuxPackages_latest.dpdk)
• linuxPackages_5_12.dpdk
• linuxPackages_5_4.dpdk
• ...

4 packages built successfully:

• linuxPackages.dpdk (linuxPackages_5_10.dpdk)
• linuxPackages_hardened.dpdk
• linuxPackages_xanmod.dpdk
• linuxPackages_zen.dpdk

4 suggestions:

• warning: unnecessary-parallel-building

  Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

  Near pkgs/os-specific/linux/dpdk/default.nix:70:3:

     |
  70 |   enableParallelBuilding = true;
     |   ^
  

• warning: name-and-version

  Did you mean to pass pname instead of name to mkDerivation?

  Near pkgs/os-specific/linux/dpdk/default.nix:13:3:

     |
  13 |   name = "dpdk-${version}" + lib.optionalString mod "-${kernel.version}";
     |   ^
  

  Near pkgs/os-specific/linux/dpdk/default.nix:14:3:

     |
  14 |   version = "21.02";
     |   ^
  

• warning: unclear-gpl

  lgpl21 is a deprecated license, please check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

  Near pkgs/os-specific/linux/dpdk/default.nix:75:5:

     |
  75 |     license = with licenses; [ lgpl21 gpl2 bsd2 ];
     |     ^
  

• warning: unclear-gpl

  gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/os-specific/linux/dpdk/default.nix:75:5:

     |
  75 |     license = with licenses; [ lgpl21 gpl2 bsd2 ];
     |     ^
  

[Mic92]

Similar to #122588

[mweinelt]

I don't believe this makes sense like this?

[jonringer]

It's from https://github.com/NixOS/nixpkgs/pull/122588/checks?check_run_id=2560790845

[mweinelt]

To clarify: aarch64 is armv8, so I don't think the comment is correct.

[jonringer]

oh, i see what you mean. Yea the comment will probably need to be updated that it just doesn't build

[jonringer]

closing in favor of #122588