Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZHF] linuxPackages.dpdk: 20.05 -> 21.02, fix build #123605

Closed
wants to merge 2 commits into from
Closed

[ZHF] linuxPackages.dpdk: 20.05 -> 21.02, fix build #123605

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7381583
linuxPackages.dpdk: 20.05 -> 21.02
jonringer May 19, 2021
9b71134
linuxPackages.dpdk: mark broken for aarch64, unsupported
jonringer May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions pkgs/os-specific/linux/dpdk/default.nix
View file
Open in desktop
Expand Up @@ -11,21 +11,25 @@ let

in stdenv.mkDerivation rec {
name = "dpdk-${version}" + lib.optionalString mod "-${kernel.version}";
version = "20.05";
version = "21.02";

src = fetchurl {
url = "https://fast.dpdk.org/rel/dpdk-${version}.tar.xz";
sha256 = "0h0xv2zwb91b9n29afg5ihn06a8q28in64hag2f112kc19f79jj8";
sha256 = "sha256-CZJKKoJVGqKZeKNoYYT4oQX1L1ZAsb4of1QLLJHpSJs=";
};

nativeBuildInputs = [
doxygen
meson
ninja
pkg-config
python3

# python3.withPackages isn't sufficient, because python3 during a
# meson build points to the one used by meson
python3.pkgs.pyelftools
python3.pkgs.sphinx
];

buildInputs = [
jansson
libbpf
Expand Down Expand Up @@ -71,5 +75,6 @@ in stdenv.mkDerivation rec {
license = with licenses; [ lgpl21 gpl2 bsd2 ];
platforms = platforms.linux;
maintainers = with maintainers; [ magenbluten orivej ];
broken = stdenv.isAarch64; # only supports armv8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this makes sense like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's from https://github.com/NixOS/nixpkgs/pull/122588/checks?check_run_id=2560790845

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify: aarch64 is armv8, so I don't think the comment is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i see what you mean. Yea the comment will probably need to be updated that it just doesn't build

};
}