Review request: Haskell package "diagrams" and dependencies. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are packages which still depend on version < 0.10, so we provide 0.9.7 here. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This package is required by diagrams-lib. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This package is required by diagrams-lib. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Starting with version 0.1.1.1, required by diagrams-core. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This is just a metapackage, so the build is going to fail and we need to fix things up next. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This package is only a metapackage and doesn't contain any source files, so we don't need to generate source code documentation at all. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
That way we have all diagrams specific stuff in one directory, which coulde make it easier for code-reuse in the future. Signed-off-by: aszlig <aszlig@redmoonstudios.org>
This temporarily reverts commit d9f3317 in order to get diagrams-cairo to build successfully for people to review. Please DO NOT cherry-pick this commit or merge it.
ghost
assigned 
|
@aszlig, those changes look fine to me. I've merged the |
|
Thanks for reviewing :-) |
12 tasks
Profpatsch
pushed a commit
that referenced
this pull request
Jun 20, 2020
Fix readme markdown syntax
ethancedwards8
pushed a commit
to ethancedwards8/nixpkgs
that referenced
this pull request
Apr 2, 2021
fonts: rewrite activation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particularily for @peti to review.
At the moment, I've splitted cmdargs into pre-0.10 and 0.10, so please ignore commit dfea5f2 and 9825e1d in the review, as i will amend it as soon as you merged in the jailbreak branch.