Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant changes
I don't see any relevant changes that should go into the NixOS changelog.
I've added the
traceroute6
binary.The build workflow for the man pages changed (SGML -> XML), but that shouldn't cause any problems.
Dependency changes:
libidn
->libidn2
(and the build system for the man pages).The code is still a bit hacky to be honest but it should be fine for now (I'll try to improve/refactor it soon).
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)Changes (git shortlog s20161105..s20180629):
Brian Norris (1):
ping: Fix signed overflow/conversion warning
Claudius Zingerli (1):
Ping: Correct rounding of timing displays
Cyril Hrubis (1):
ping_common.c: POLLERRR is ignored in events
David Heidelberg (37):
Merge pull request #67 from locasity/master
Merge pull request #69 from nmeyerhans/traceroute6
Merge pull request #87 from jsynacek/fix-pmtudisc
gitignore: prepare for Meson
meson: add experimental meson buildsystem support
ping: fix typo in error tos error message
ping: parsetos verification is enough, allow decimal values
ping: flowinfo: fixup checks for flowinfo and also add decimal numbers support
ping: fix conflicting defines
remove iputils.spec
RELNOTES: deprecated in favor of git history & github
travis-ci: cleanup and switch to Ubuntu 14.04 build
doc: convert from converting SGML to XML
Merge pull request #89 from metan-ucw/master
ping: fix incorrect packet loss calculation
LICENSE: add information about licenses
doc: ping - document mdev behaviour
LICENSE: convert BSD4 to BSD3 license
licenses: fill missing clockdiff.c and ping_common.c license
cleanup: really old code, simplify little bit
Merge pull request #103 from kerolasa/remove-libsysfs
Merge pull request #107 from jsynacek/master
Merge pull request #106 from kerolasa/tracepath-asan
Merge pull request #97 from nmav/tmp-idn2
Merge pull request #108 from Whissi/symlinked-tracepath-call
Merge pull request #101 from pevik/cleanup/working_recverr
Merge pull request #100 from pevik/fix-regression-57
Merge pull request #113 from pevik/doc/ping-modern-commands
Merge pull request #114 from pevik/doc/ping-no-need-to-use-link-specification
Merge pull request #116 from pevik/fix-readme
Merge pull request #75 from soheilhy/ping-errqueue
Merge pull request #126 from deastoe/ping6-device-bind
Merge pull request #123 from bbczeuz/dev_zseng_fix_time_rounding
Merge pull request #121 from pingz/patch-1
Merge pull request #131 from pevik/fix-ping-on-C-locale
Merge pull request #134 from computersforpeace/warnings
iputils-s20180629
Duncan Eastoe (1):
ping6: Fix device binding
Jan Synacek (5):
ping: prevent possible double free after cap_free()
arping: exit if network disappears while running
fix multicast setsockopt calls on big endian
ping: fix pmtu discovery for ipv6
ping: remove spurious error message
Nathaniel White (3):
traceroute6: Fix use after free for hostname
traceroute6: Fix leaking the idn memory
traceroute6: Fix traceroute to IPv6 address
Nikos Mavrogiannopoulos (6):
arping,tracepath: removed unused idna header
traceroute6: use getaddrinfo IDNA conversion
ping6: simplified IDNA usage
ping: use libidn2 instead of libidn
.travis.yml: install libidn2
.travis.yml: corrected variable values in matrix
Noah Meyerhans (1):
traceroute6: Fix udp packet port specification.
Petr Vorel (6):
ping: Remove workaround for bug in IP_RECVERR on raw sockets
Revert "correctly initialize first hop"
doc/ping: Replace deprecated commands in "SEE ALSO" section
doc/ping: Update Interface section
docs: Tiny fixes in README.md
ping: Fix ping name encoded using ACE on C locale
Sami Kerola (2):
arping: do not use libsysfs to read from /sys
tracepath: fix heap-buffer-overflow [asan]
Seishinryohosha (1):
tracepath,doc: Added -4, -6 Parameter in doc and void usage(void)
Singh (1):
Add strict pattern matching on response when pattern was provided
Soheil Hassas Yeganeh (1):
ping: read from error queue when POLLERR is set
Thomas Deutschmann (1):
tracepath: Support calling
tracepath
astracepath4
ortracepath6
pingz (1):
fix checksum always success in IPv4 ping.